Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: terminal message on Actor.exit() #172

Merged
merged 11 commits into from
Mar 9, 2023
Merged

feat: terminal message on Actor.exit() #172

merged 11 commits into from
Mar 9, 2023

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Feb 14, 2023

packages/apify/src/actor.ts Outdated Show resolved Hide resolved
@barjin barjin marked this pull request as draft February 14, 2023 16:37
@barjin
Copy link
Contributor Author

barjin commented Feb 14, 2023

The last commit contains a "breaking" change in types - if somebody uses helper types to extract the return types of our methods. ideas welcome

@B4nan B4nan marked this pull request as ready for review March 2, 2023 10:03
packages/apify/src/actor.ts Outdated Show resolved Hide resolved
packages/apify/src/actor.ts Outdated Show resolved Hide resolved
packages/apify/src/actor.ts Outdated Show resolved Hide resolved
@barjin barjin force-pushed the feat/statusMsgOnExit branch from 1b140da to 9a04b37 Compare March 9, 2023 10:36
packages/apify/package.json Outdated Show resolved Hide resolved
packages/apify/src/actor.ts Outdated Show resolved Hide resolved
@barjin barjin merged commit e0feca8 into master Mar 9, 2023
@barjin barjin deleted the feat/statusMsgOnExit branch March 9, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants