Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apify): add decryption for input secrets #83

Merged
merged 8 commits into from
Oct 7, 2022

Conversation

drobnikj
Copy link
Member

@drobnikj drobnikj commented Oct 7, 2022

Implementation for decryption of input secrets.

  • move APIFY_INPUT_SECRETS_PRIVATE_KEY_PASSPHRASE and APIFY_INPUT_SECRETS_PRIVATE_KEY_FILE into @apify/consts

I still didn't comment or document the secrets at all, I would do it once we test it internally in team and release it into public.

@drobnikj drobnikj requested a review from fnesveda October 7, 2022 07:00
@drobnikj drobnikj marked this pull request as ready for review October 7, 2022 07:01
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I found just one small thing.

packages/apify/src/actor.ts Outdated Show resolved Hide resolved
Comment on lines -67 to -68
"playwright": "*",
"puppeteer": "*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should stay here, no? They're used in the e2e tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see if it breaks it, they are still in the lock file, and as long as we dont directly import them in the tests, they dont have to be specified here.

E2E tests for this branch running here: https://github.com/apify/apify-sdk-js/actions/runs/3203931243

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's gonna work, since they're still in the lockfile, but they're imported from the scraper source code, which is then imported dynamically through here:

await import(`../../packages/actor-scraper/${scraper}/dist/main.js`);

But I don't know how it works with the workspaces, if you reference a workspace which has them listed as dependencies, maybe you don't need to list them as your own dependencies? I guess it's fine in that case then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed so it should be fine.

packages/apify/src/configuration.ts Outdated Show resolved Hide resolved
test/apify/actor.test.ts Outdated Show resolved Hide resolved
@drobnikj drobnikj merged commit 78bb990 into master Oct 7, 2022
@drobnikj drobnikj deleted the feat/actor_input_secrets branch October 7, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants