From 2954024950832b09a5a3c4f75eb8629f9f1e4c76 Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Wed, 19 Feb 2025 20:05:08 +0100 Subject: [PATCH] docs: update code example for Scrapy guide --- docs/02_guides/code/scrapy_project/src/__main__.py | 4 ++-- docs/02_guides/code/scrapy_project/src/settings.py | 1 + docs/02_guides/code/scrapy_project/src/spiders/__init__.py | 2 ++ docs/02_guides/code/scrapy_project/src/spiders/title.py | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/02_guides/code/scrapy_project/src/__main__.py b/docs/02_guides/code/scrapy_project/src/__main__.py index 97298fe9..bc2cf9ba 100644 --- a/docs/02_guides/code/scrapy_project/src/__main__.py +++ b/docs/02_guides/code/scrapy_project/src/__main__.py @@ -1,10 +1,10 @@ from __future__ import annotations -from twisted.internet import asyncioreactor +from scrapy.utils.reactor import install_reactor # Install Twisted's asyncio reactor before importing any other Twisted or # Scrapy components. -asyncioreactor.install() # type: ignore[no-untyped-call] +install_reactor('twisted.internet.asyncioreactor.AsyncioSelectorReactor') import os diff --git a/docs/02_guides/code/scrapy_project/src/settings.py b/docs/02_guides/code/scrapy_project/src/settings.py index ed51668a..62e11bfb 100644 --- a/docs/02_guides/code/scrapy_project/src/settings.py +++ b/docs/02_guides/code/scrapy_project/src/settings.py @@ -5,4 +5,5 @@ ROBOTSTXT_OBEY = True SPIDER_MODULES = ['src.spiders'] TELNETCONSOLE_ENABLED = False +# Do not change the Twisted reactor unless you really know what you are doing. TWISTED_REACTOR = 'twisted.internet.asyncioreactor.AsyncioSelectorReactor' diff --git a/docs/02_guides/code/scrapy_project/src/spiders/__init__.py b/docs/02_guides/code/scrapy_project/src/spiders/__init__.py index f63ac977..3745a12c 100644 --- a/docs/02_guides/code/scrapy_project/src/spiders/__init__.py +++ b/docs/02_guides/code/scrapy_project/src/spiders/__init__.py @@ -1 +1,3 @@ from .title import TitleSpider + +__all__ = ['TitleSpider'] diff --git a/docs/02_guides/code/scrapy_project/src/spiders/title.py b/docs/02_guides/code/scrapy_project/src/spiders/title.py index 9bb25b34..408d3106 100644 --- a/docs/02_guides/code/scrapy_project/src/spiders/title.py +++ b/docs/02_guides/code/scrapy_project/src/spiders/title.py @@ -10,7 +10,7 @@ if TYPE_CHECKING: from collections.abc import Generator - from scrapy.responsetypes import Response + from scrapy.http.response import Response class TitleSpider(Spider):