Skip to content

chore: Use shared mode ApifyStorageClient for test_concurrent_processing_simulation #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: Use shared mode ApifyStorageClient for test_concurrent_processing_simulation #662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions tests/integration/actor/test_actor_request_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
import asyncio
from typing import TYPE_CHECKING

import pytest

from .._utils import generate_unique_resource_name
from apify import Actor
from apify._models import ActorRun
Expand Down Expand Up @@ -387,16 +385,23 @@ async def main() -> None:
assert run_result.status == 'SUCCEEDED'


@pytest.mark.skip(
reason='The Apify RQ client is not resilient to concurrent processing, making this test flaky. See issue #529.'
)
async def test_concurrent_processing_simulation(
make_actor: MakeActorFunction,
run_actor: RunActorFunction,
) -> None:
"""Test simulation of concurrent request processing."""

async def main() -> None:
from crawlee import service_locator

from apify.storage_clients import ApifyStorageClient, SmartApifyStorageClient

# Use `request_queue_access='shared' for concurrent access`
service_locator.set_storage_client(
SmartApifyStorageClient(
cloud_storage_client=ApifyStorageClient(request_queue_access='shared'),
)
)
async with Actor:
rq = await Actor.open_request_queue()
Actor.log.info('Request queue opened')
Expand Down
Loading