fix: wait for persist state listeners to run when event manager closes #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
approved these changes
Aug 24, 2022
B4nan
approved these changes
Aug 24, 2022
vladfrangu
force-pushed
the
fix/wait-for-persist-state-listeners-to-process-on-event-manager-close
branch
from
2d50f78
to
adf0075
Compare
vladfrangu
changed the title
vladfrangu
deleted the
fix/wait-for-persist-state-listeners-to-process-on-event-manager-close
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #1463 by ensuring the persist state listeners are executed when events.close is called
For the actor users, we also need apify/apify-sdk-js#49