fix: enqueueLinks should respect full URL of the current request for relative link resolution
#1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
changed the title
enqueueLinks should respect full URL of the current for relative link resolutionenqueueLinks should respect full URL of the current request for relative link resolution
mnmkng
approved these changes
Jul 27, 2022
Comment on lines
+515
to
+516
| originalRequestUrl: crawlingContext.request.url, | ||
| finalRequestUrl: crawlingContext.request.loadedUrl, |
There was a problem hiding this comment.
Pretty big change so I hope it does not break something else 😅
There was a problem hiding this comment.
Those two are used directly only for relative link resolution, where we need full URL, so I believe this should be safe. We explicitly use just the origin from them in the resolveBaseUrlForEnqueueLinksFiltering method.
…ve link resolution
B4nan
force-pushed
the
browser-enq-relative-links
branch
from
01a7755
to
8270998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.