feat: add RetryRequestError + add error to the context for BC
#1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnmkng
requested changes
Aug 5, 2022
| @@ -33,6 +33,7 @@ import { | |||
| Statistics, | |||
| purgeDefaultStorages, | |||
| validators, | |||
| RetryRequest, | |||
There was a problem hiding this comment.
I haven't noticed before, but shouldn't this be named RetryableError or RetryRequestError or something?
There was a problem hiding this comment.
Yes, should be *Error to make sure people understand its something to throw, not to return.
I do like RetryRequestError name better, but would go with RetryableError as its consistent with NonRetryableError we already have.
B4nan
requested changes
Aug 10, 2022
| @@ -33,6 +33,7 @@ import { | |||
| Statistics, | |||
| purgeDefaultStorages, | |||
| validators, | |||
| RetryRequest, | |||
There was a problem hiding this comment.
Yes, should be *Error to make sure people understand its something to throw, not to return.
I do like RetryRequestError name better, but would go with RetryableError as its consistent with NonRetryableError we already have.
Co-authored-by: Martin Adámek <banan23@gmail.com>
B4nan
reviewed
Aug 10, 2022
Co-authored-by: Martin Adámek <banan23@gmail.com>
B4nan
approved these changes
Aug 10, 2022
B4nan
changed the title
RetryRequestError + add error to the context for BC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the error to the crawling context for the error handlers.
Since you can throw anything, the correct type for errors in the error handlers is unknown instead of
Error, so this PR fixes that too.