Java client refactor #1

Merged
merged 3 commits into from Apr 26, 2012

Conversation

Projects
None yet
2 participants
Contributor

tnine commented Apr 25, 2012

Now uses the java client and wraps them with android async calls

If we should really rename one of these or we will regret it from an API support standpoint

I wonder if we should wrap these in a struct - number of args is confusing from api standpoint

Contributor

tnine commented Apr 25, 2012

Yeah, I agree, there are quite a few args. It's essentially just a wrapper to the java client, which is extracted from the code base in master. Do we want to merge this now for backwards compatibility with 0.0.1, then refactor it for a new release version later?

zznate commented Apr 26, 2012

really depends on when it's going to be "out there" API wise. The longer we wait the harder it will be do fix. Given what else is on the table though, we may have no choice but to go for the ugly. But that makes me sad somehow.

zznate commented Apr 26, 2012

grumble. needs to get down and this is wound kinda tight. ack-ing. thx @tnine

zznate pushed a commit that referenced this pull request Apr 26, 2012

@zznate zznate merged commit 6a31177 into master Apr 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment