Support other payment methods (Mt. Gox / Bitcoin) #22

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@ripper234

It seems that Amazon Money transfer services are currently only available in the United States.
I've added support for Bitcoin (off by default).

This pull request contains:

  1. Small code changes to make the payment method generic
  2. Adding Mt. Gox as a payment method

To enable it, you need to:

  1. Understand what Bitcoins are (http://bitcoin.org/ and http://weusecoins.com/ are a good start)
  2. Register for an Mt. Gox merchant account at http://mtgox.com/
  3. Create a Checkout Button via Mt. Gox
  4. Copy the Payment URL into preorder_controller
  5. Uncomment the Mt. Gox submit button in app/views/preorder/checkout.html.erb
@ripper234

This comment has been minimized.

Show comment Hide comment
@ripper234

ripper234 Dec 26, 2012

BTW, sorry for accidentally committing modifications to Gemfile.lock - please ignore that file.

See http://stackoverflow.com/questions/14034561/should-gemfile-lock-be-committed-to-source-control-on-windows

BTW, sorry for accidentally committing modifications to Gemfile.lock - please ignore that file.

See http://stackoverflow.com/questions/14034561/should-gemfile-lock-be-committed-to-source-control-on-windows

@dkisselev

This comment has been minimized.

Show comment Hide comment
@dkisselev

dkisselev Jan 25, 2013

I believe this is a typo that accidentally got pushed into the commit.

I believe this is a typo that accidentally got pushed into the commit.

This comment has been minimized.

Show comment Hide comment
@ripper234

ripper234 Jan 25, 2013

Thanks.

Thanks.

@Jarred-Sumner

This comment has been minimized.

Show comment Hide comment
@Jarred-Sumner

Jarred-Sumner Jan 30, 2013

Contributor

Thanks for the hard work!

I don't think Selfstarter should support other payment methods unless there is a standard way of doing so. For now, you can keep a fork of Selfstarter using a separate payment provider. selfstarter-stripe is a good example of this.

That being said, there are a couple major issues:

  1. It's not clear where the data we retrieve from Mt. Gox is stored. We need some sort of reference back to the Order.
  2. Enabling/disabling functionality by uncommenting code may work well for an internal project, but for an open source project, it needs to be a flag in config/settings.yml.

Additionally, the payment URL should be set in config/settings.yml, in the same way that the amazon_token is.

Contributor

Jarred-Sumner commented Jan 30, 2013

Thanks for the hard work!

I don't think Selfstarter should support other payment methods unless there is a standard way of doing so. For now, you can keep a fork of Selfstarter using a separate payment provider. selfstarter-stripe is a good example of this.

That being said, there are a couple major issues:

  1. It's not clear where the data we retrieve from Mt. Gox is stored. We need some sort of reference back to the Order.
  2. Enabling/disabling functionality by uncommenting code may work well for an internal project, but for an open source project, it needs to be a flag in config/settings.yml.

Additionally, the payment URL should be set in config/settings.yml, in the same way that the amazon_token is.

@ripper234

This comment has been minimized.

Show comment Hide comment
@ripper234

ripper234 Feb 16, 2013

Why don't you think Selfstarter should support other payment methods?
If the code can be isolated in its own module, then this kind of stuff only helps selfstarter, no?

As I wrote this code mostly as a POC, and it never got beyond this phase, I understand how you might not want to pull it for now. If I ever go back to it and take it to the next level, I'll let you know and issue another pull request.

Why don't you think Selfstarter should support other payment methods?
If the code can be isolated in its own module, then this kind of stuff only helps selfstarter, no?

As I wrote this code mostly as a POC, and it never got beyond this phase, I understand how you might not want to pull it for now. If I ever go back to it and take it to the next level, I'll let you know and issue another pull request.

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Jun 8, 2013

Now that Bitcoin is more popular, would it be possible to support Bitcoin payments without Mt.Gox?

ghost commented Jun 8, 2013

Now that Bitcoin is more popular, would it be possible to support Bitcoin payments without Mt.Gox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment