refactor(ui): update swagger-ui to v4 - #2066
Merged
Merged
Conversation
Member
Author
|
I think I got all problems fixed, have to triple check that. |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
volkflo
force-pushed
the
update-swagger-ui-to-v4
branch
from
May 31, 2022 06:17
4cf7026 to
486d784
Compare
Changed some methods according to the documentation. The behaviour is now the same as in the apiman-developer-portal.
volkflo
force-pushed
the
update-swagger-ui-to-v4
branch
from
May 31, 2022 06:32
486d784 to
2e0d3c1
Compare
volkflo
marked this pull request as ready for review
May 31, 2022 06:37
Member
Author
|
Seems to work fine now |
Member
|
Rebased onto latest deps |
msavy
changed the title
Member
|
Backgrounds of samples don't look right. Is this just a CSS thing? |
Member
|
Looks like it's caused by prism.js CSS (used also for markdown editor code section). prism.css#L7 code[class*="language-"],
pre[class*="language-"] {
color: black; // <--- this one by the looks of it.
} |
Member
|
I'm not sure if it was a caching issue as I can't see the issue any more! |
msavy
requested changes
Jul 7, 2022
msavy
left a comment
msavy
left a comment
Member
There was a problem hiding this comment.
Putting on request changes, but might just be clarifications required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.