Skip to content

fix(manager-api): client republish and/or unregister when breaking contracts#2123

Merged
msavy merged 7 commits into
apiman:masterfrom
msavy:delete-ensure-unpublish
Jul 8, 2022
Merged

fix(manager-api): client republish and/or unregister when breaking contracts#2123
msavy merged 7 commits into
apiman:masterfrom
msavy:delete-ensure-unpublish

Conversation

@msavy

@msavy msavy commented Jun 22, 2022

Copy link
Copy Markdown
Member

No description provided.

@msavy msavy changed the title ensure republish and/or unregister in case of deleting contracts fix(manager-api): ensure republish and/or unregister in case of deleting contracts Jun 22, 2022
@msavy
msavy force-pushed the master branch 2 times, most recently from 6e04b50 to d0ce08d Compare June 24, 2022 15:50
@msavy
msavy force-pushed the delete-ensure-unpublish branch from a692ec4 to 5142c24 Compare June 24, 2022 20:06
@volkflo

volkflo commented Jun 28, 2022

Copy link
Copy Markdown
Member

Okay the logic works fine, only problem is that the UI is not refreshed after something happens automatically in the background.

Comment thread manager/ui/war/plugins/api-manager/ts/client/client-contracts.ts Outdated
@msavy

msavy commented Jul 8, 2022

Copy link
Copy Markdown
Member Author

Thanks for fixing up the tests for this, @volkflo. Was going to do that this morning, but looks like you already did it 😎.

@msavy msavy left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for final checks

@msavy msavy changed the title fix(manager-api): ensure republish and/or unregister in case of deleting contracts fix(manager-api): client republish and/or unregister when breaking contracts Jul 8, 2022
@msavy
msavy merged commit ac2841f into apiman:master Jul 8, 2022
@msavy
msavy deleted the delete-ensure-unpublish branch July 8, 2022 09:04
@msavy

msavy commented Jul 8, 2022

Copy link
Copy Markdown
Member Author

Thanks for your contributions to this, @volkflo

Thanks to team at Scheer PAS for contributing to and sponsoring this fix to Apiman 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaking contract does not automatically republish/retire; can leave API on gateway(s).

2 participants