fix(manager-api): client republish and/or unregister when breaking contracts #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msavy
changed the title
msavy
force-pushed
the
master
branch
2 times, most recently
from
6e04b50 to
d0ce08d
Compare
msavy
force-pushed
the
delete-ensure-unpublish
branch
from
a692ec4 to
5142c24
Compare
|
Okay the logic works fine, only problem is that the UI is not refreshed after something happens automatically in the background. |
volkflo
reviewed
Jun 30, 2022
.../test/api/src/test/resources/test-plan-data/contracts/contracts/020_create-contract.resttest
Show resolved
Hide resolved
…rs a client automatically
msavy
commented
Jul 8, 2022
manager/api/beans/src/main/java/io/apiman/manager/api/beans/contracts/ContractBean.java
Show resolved
Hide resolved
msavy
commented
Jul 8, 2022
manager/api/rest-impl/src/main/java/io/apiman/manager/api/service/ActionService.java
Outdated
Show resolved
Hide resolved
msavy
commented
Jul 8, 2022
manager/ui/war/plugins/api-manager/ts/client/client-contracts.ts
Outdated
Show resolved
Hide resolved
|
Thanks for fixing up the tests for this, @volkflo. Was going to do that this morning, but looks like you already did it 😎. |
msavy
changed the title
|
Thanks for your contributions to this, @volkflo Thanks to team at Scheer PAS for contributing to and sponsoring this fix to Apiman 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.