feat(manager-api): add column order index for Api Plans so users can explicitly order plans in UI #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@volkflo please review and let me know |
…explicitly order plans in UI This feature is used by the API Developer Portal also. Closes: apiman#1639
|
Thanks to Florian, Olli, Bastian, Christian, and the team at Scheer PAS for contributing to and sponsoring this enhancement to Apiman. |
msavy
changed the title
volkflo
reviewed
Jul 8, 2022
...pi/exceptions/src/main/java/io/apiman/manager/api/rest/exceptions/util/ExceptionFactory.java
Show resolved
Hide resolved
manager/api/rest-impl/src/main/java/io/apiman/manager/api/service/ApiService.java
Show resolved
Hide resolved
It is simply that the UI was already using the existing endpoint in several locations and I could avoid changing any code dealing with that. But to keep the API consistent with the policy chain reordering, and for other use-cases (e.g. CLI), I think it's best to add the reorder endpoint also. |
|
Okay cool, thanks for the comments 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@volkflo initial version with UI -- needs a little tidying up + tests before committing, but seems to work well.
Sorry for slowness due to holidays.
Thanks to Florian, Olli, Bastian, Christian, and the team at Scheer PAS for contributing to and sponsoring this enhancement to Apiman.