feat: add rejection to contract approval workflow#2175
Merged
Conversation
msavy
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
msavy
previously approved these changes
Jul 8, 2022
msavy
left a comment
msavy
left a comment
Member
There was a problem hiding this comment.
Some small nits to resolve, but overall looks good.
Thanks for collaborating on this!
volkflo
force-pushed
the
contract-rejection
branch
from
efedc3e to
f11318c
Compare
Added rejection to the approval workflow (including new events and notifications). Users are allowed to pass in a `rejectionReason` via the UI form that is part of the event/notifications. Rejected contracts will be automatically deleted once the event was emitted. Closes: #1679 Co-authored-by: Marc Savy <marc@rhymewithgravy.com> Co-authored-by: Bastian Gembalczyk <bastian.gembalczyk@scheer-group.com>
volkflo
force-pushed
the
contract-rejection
branch
from
f11318c to
95a6a31
Compare
msavy
approved these changes
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1679