Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager-api-jpa): parse filter number into same numeric data type as target field #2284

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

msavy
Copy link
Member

@msavy msavy commented Aug 25, 2022

Previously, we were assuming all the fields were Long. In some cases they are Integer and this causes a data type mismatch with certain target fields.

Fixes: #2283

… as target field.

Previously, we were assuming all the fields were `Long`. In some cases they are `Integer`
and this causes a data type mismatch with certain target fields.

Fixes: #2283
@msavy msavy requested a review from BastianGem August 25, 2022 11:28
@msavy msavy self-assigned this Aug 25, 2022
@cypress
Copy link

cypress bot commented Aug 25, 2022



Test summary

17 0 0 0


Run details

Project Apiman
Status Passed
Commit ea1134d ℹ️
Started Aug 25, 2022 11:41 AM
Ended Aug 25, 2022 11:43 AM
Duration 02:01 💡
OS Linux Ubuntu - 20.04
Browser Electron 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@BastianGem BastianGem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@msavy msavy merged commit 1218417 into master Aug 25, 2022
@msavy
Copy link
Member Author

msavy commented Aug 25, 2022

Thanks!

msavy added a commit that referenced this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter for endpoint '/search/apis' throws errors
2 participants