feat(metrics-es): allow logging metrics to JSON file with write-to option
#2293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will likely wait for 3.1 to merge this, but let's see. |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
msavy
force-pushed
the
es-log-to-file-2
branch
from
cad0a5d to
0b0b21e
Compare
msavy
changed the title
write-to optionwrite-to option
To facilitate scrape-based metrics, this commit allows Apiman's ES metrics (as JSON) to be written to a log file. The specific behaviour is controlled via whatever logging framework is used. It is possible to write to any of: `remote` (ES server), `log` The configuration provided in this commit calls the output `metrics.log`, but we the user can change this, as per their preferences. Async logging is used, where possible, to mitigate the impact on performance, as this is likely to generate a considerable number of log writes. Fixes: #2100
msavy
force-pushed
the
es-log-to-file-2
branch
from
0b0b21e to
49ad83e
Compare
msavy
force-pushed
the
master
branch
6 times, most recently
from
c38af33 to
f87f7c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate scrape-based metrics, this commit allows Apiman's ES metrics (as JSON) to be written
to a log file. The specific behaviour is controlled via whatever logging framework is used.
It is possible to write to any of:
remote(ES server),logThe configuration provided in this commit calls the output
metrics.log, but we the user can changethis, as per their preferences. Async logging is used, where possible, to mitigate the impact on
performance, as this is likely to generate a considerable number of log writes.
Thanks again to Terry, Russel, Joe, Colin, LN, Shivraj, and the rest of the team.
Fixes: #2100