Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egltrace/android: Write to /sdcard rather than /data #149

Closed
wants to merge 2 commits into from

Conversation

nigels-com
Copy link
Contributor

Ordinarily apitrace on Android requires a rooted device.
Change the output destination from /data to /sdcard so that
applications with apitrace built-in with WRITE_EXTERNAL_STORAGE
permission can write traces on non-rooted devices too.

Ordinarily apitrace on Android requires a rooted device.
Change the output destination from /data to /sdcard so that
applications with apitrace built-in with WRITE_EXTERNAL_STORAGE
permission can write traces on non-rooted devices too.
@jrfonseca
Copy link
Member

Sounds good but I don't use Android. Assuming the others who do (e.g. @amonakov) have no objection, please update the instructions Dalvik.markdown too.

PS: Probably it would be better to send Android related review requests to the mailing list, as I really don't know enough to make an opinion.

@nigels-com
Copy link
Contributor Author

Sure, will do.

Update Dalvik.markdown documentation to reflect the change from
/data to /sdcard for trace output.  Could/should the egltrace.so
also go in /sdcard for simplicity?
@amonakov
Copy link
Member

NAK. This is going to break tracing applications without sdcard write permission when /sdcard is a fat32 partition, or resides on a fuse filesystem not supporting chmod 0777.

A better approach would be to place trace files into /data/data/$procname. I'll try to submit patches for that soon.

@nigels-com
Copy link
Contributor Author

Perhaps then an optional overide that can be set via an environment variable or directly by the linked application?
Using apitrace as a library (rather than invisible interposer) suggests that the application ought to decide where the output ought to go.

  • Nigel

@amonakov
Copy link
Member

Well, an environment variable already exists: TRACE_FILE.

@nigels-com
Copy link
Contributor Author

Closing this in favor of pull request 150.
#150
Thanks all!

@nigels-com nigels-com closed this Jun 24, 2013
amonakov added a commit that referenced this pull request Feb 28, 2014
So that applications with apitrace built-in with WRITE_EXTERNAL_STORAGE
permission can write traces on non-rooted devices too.

See issue #149.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants