Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

apitrace: Parse comma-separated list in commandline #274

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

lawlove commented Jun 7, 2014

Description
In the command line argument list for --calls (and --frames), allow a
single comma-separated mixed list of files and/or ranges instead of
multiple option calls for each one.

E.g., instead of

apitrace trim --calls=@foo.calls --calls=0-20 --calls=100-150 \
              --calls=@goo.calls --calls=...

allow

apitrace trim --calls=@foo.calls,0-20,100-150,@goo.calls,..

which is merged into one callset list of their union.

Details
CallSet class member function CallSet::merge() parses for comma-delimited
tokens in the input option string and adds them to the CallSet list

Testing
Tests have been added to the apitrace-tests repository.

Testing in apitrace-tests done on both
Linux: 3.14-1-amd64 #1 SMP Debian 3.14.4-1 (2014-05-13) x86_64 GNU/Linux
Windows 7: MINGW32_NT-6.1 1.0.12(0.46/3/2) 2012-07-05 14:56 i686 unknown

100% passing.

Signed-off-by: Lawrence L Love lawrencex.l.love@intel.com

@lawlove lawlove apitrace: Parse comma-separated list in commandline
* Description
In the command line argument list for --calls (and --frames), allow a
single comma-separated mixed list of files and/or ranges instead of
multiple option calls for each one.
E.g., instead of

    apitrace trim --calls=@foo.calls --calls=0-20 --calls=100-150 \
                  --calls=@goo.calls --calls=...

allow

    apitrace trim --calls=@foo.calls,0-20,100-150,@goo.calls,..

which is merged into one callset list of their union.

* Details
CallSet class member function CallSet::merge() parses for comma-delimited
tokens in the input option string and adds them to CallSet list

* Testing
Tests have been added to the apitrace-tests repository.

Testing in apitrace-tests done on both
Linux: 3.14-1-amd64 #1 SMP Debian 3.14.4-1 (2014-05-13) x86_64 GNU/Linux
Windows 7: MINGW32_NT-6.1 1.0.12(0.46/3/2) 2012-07-05 14:56 i686 unknown

100% passing.

Signed-off-by: Lawrence L Love <lawrencex.l.love@intel.com>
3b2e002

@jrfonseca jrfonseca added the CLI label Jun 7, 2014

Owner

jrfonseca commented Sep 15, 2015

Pushed. Sorry for the long delay.

@jrfonseca jrfonseca closed this Sep 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment