Update external Javascript libraries #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
EerikSaksi
force-pushed
the
update-cdn-libraries
branch
from
4053244
to
4676d09
Compare
markkuriekkinen
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Thanks! I think I will add the integrity attribute to script and link elements before merging this (as well as crossorigin="anonymous" and referrerpolicy="no-referrer" attributes).
At least jQuery has also had newer releases during the spring so I can update it further.
assets/js/aplus.js
Outdated
| @@ -309,7 +309,7 @@ $(function() { | |||
| copyTargetCounter += 1; | |||
| } | |||
|
|
|||
| hljs.highlightBlock(codeBlock[0]); | |||
| hljs.highlightElement(codeBlock[0]) | |||
There was a problem hiding this comment.
No reason to remove the ending semicolon ;?
SRI = Subresource Integrity, basically the integrity attribute on link and script elements. https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity
markkuriekkinen
force-pushed
the
update-cdn-libraries
branch
from
4676d09
to
fc44cdb
Compare
markkuriekkinen
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update external Javascript libraries
Fixes #1031
What?
Update the external Javascript libraries linked to by CDNs
Why?
Avoid security issues and get newest features
How?
Check newest version, test the libraries, look at release notes for breaking changes. Detailed testing in the manual testing section below.
Fixes #1031
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
highlight.js upgrade to 11.7.0
Tested submitting functions.py in Hello Python 6.2 and reviewed my submission which calls the highlightCode jQuery plugin. Also ensured that code with the
highlighttag is highlighted normally.The
highlightBlockfunction is being deprecated and therefore replaced withhighlightElementclipboard.js
The upgrade to v2 seems to cause the breaking change that Clipboard needs to be initialized with ClipboardJS instead. I searched all places where Clipboard is initialized and replaced this with ClipboardJS. I also tested all places where I made this replacement (copy user token, copy submission code in the inspect page, deadline deviations which uses search select form). The API for event handling seems to be the same (
clipboard.on('success')clipboard.on('error'))Bootstrap multiselect
We shouldn't upgrade to 1.x because this might be incompatible with Bootstrap 3, so I didn't change this.
Datatables
Made sure that the datatables didn't change behavior in the /teachers/results page,
JQuery
The upgrade from 3.6.0 to 3.6.1 seemed to introduce no breaking changes. I still made sure pages which use JQuery plugins had no issues.
https://blog.jquery.com/2022/08/26/jquery-3-6-1-maintenance-release/
Did you test the changes in
Translation
Programming style
Have you updated the README or other relevant documentation?
Is it Done?
Clean up your git commit history before submitting the pull request!