New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4 install issue #333

Closed
steveo7 opened this Issue Apr 12, 2013 · 10 comments

Comments

Projects
None yet
7 participants
@steveo7

steveo7 commented Apr 12, 2013

Dont know if you are looking for feedback on Rails 4 beta1 testing, but I hit a little one when running rails g gmaps4rails:install, it produces js by default.

When the install checks to see if the asset pipeline is enabled it looks at Rails.configuration.assets.enabled which is no longer set by default in config/application.rb. I suppose It could return when Rails 4 is officially released.

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Jul 10, 2013

👍 this gem needs some Rails 4 luvin.

GantMan commented Jul 10, 2013

👍 this gem needs some Rails 4 luvin.

@tmedford

This comment has been minimized.

Show comment
Hide comment
@tmedford

tmedford commented Aug 1, 2013

I agree

@dogweather

This comment has been minimized.

Show comment
Hide comment
@dogweather

dogweather Sep 5, 2013

Hmm. I get "Uncaught ReferenceError: Gmaps is not defined" in Rails 4, using either the latest gem, or getting it direct from github. I'm guessing that Rails 4 isn't supported? Is there a workaround?

dogweather commented Sep 5, 2013

Hmm. I get "Uncaught ReferenceError: Gmaps is not defined" in Rails 4, using either the latest gem, or getting it direct from github. I'm guessing that Rails 4 isn't supported? Is there a workaround?

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Sep 5, 2013

I have the gem working in a Rails 3 to Rails 4 upgrade site.

The project is nothing beautiful (yet) but you can view all the code here, it mayyyyy help if you get desperate: https://github.com/IconoclastLabs/teamweb

I'm on this issue bc I wanted coffeescript and not .js

GantMan commented Sep 5, 2013

I have the gem working in a Rails 3 to Rails 4 upgrade site.

The project is nothing beautiful (yet) but you can view all the code here, it mayyyyy help if you get desperate: https://github.com/IconoclastLabs/teamweb

I'm on this issue bc I wanted coffeescript and not .js

@dogweather

This comment has been minimized.

Show comment
Hide comment
@dogweather

dogweather Sep 5, 2013

Thanks! I got it working in Rails 4 by simply moving the vendor/javascript/gmaps4rails directory into app/assets/javascripts; the default "require_tree ." picked it right up. I'll go back and figure out how to refer to it via the sprockets command.

dogweather commented Sep 5, 2013

Thanks! I got it working in Rails 4 by simply moving the vendor/javascript/gmaps4rails directory into app/assets/javascripts; the default "require_tree ." picked it right up. I'll go back and figure out how to refer to it via the sprockets command.

@Richenglish

This comment has been minimized.

Show comment
Hide comment
@Richenglish

Richenglish Sep 11, 2013

Just installed gem into a new rails 4 app. The js and css files got installed into the public directory, had to move them into assets dir to get it working. Works now and no further issues so far with 4.

Richenglish commented Sep 11, 2013

Just installed gem into a new rails 4 app. The js and css files got installed into the public directory, had to move them into assets dir to get it working. Works now and no further issues so far with 4.

@mpoli

This comment has been minimized.

Show comment
Hide comment
@mpoli

mpoli Sep 19, 2013

Moving the javascripts to /app/assets or creating a index.js file and having them in /vendor works, BUT yield :scripts is embedding <script src="/javascripts/gmaps4rails/gmaps4rails.base.js"></script> and <script src="/javascripts/gmaps4rails/gmaps4rails.googlemaps.js"></script> which throws routing errors: ActionController::RoutingError (No route matches [GET] "/javascripts/gmaps4rails/gmaps4rails.base.js"): and ActionController::RoutingError (No route matches [GET] "/javascripts/gmaps4rails/gmaps4rails.googlemaps.js"):

mpoli commented Sep 19, 2013

Moving the javascripts to /app/assets or creating a index.js file and having them in /vendor works, BUT yield :scripts is embedding <script src="/javascripts/gmaps4rails/gmaps4rails.base.js"></script> and <script src="/javascripts/gmaps4rails/gmaps4rails.googlemaps.js"></script> which throws routing errors: ActionController::RoutingError (No route matches [GET] "/javascripts/gmaps4rails/gmaps4rails.base.js"): and ActionController::RoutingError (No route matches [GET] "/javascripts/gmaps4rails/gmaps4rails.googlemaps.js"):

@apneadiving

This comment has been minimized.

Show comment
Hide comment
@apneadiving

apneadiving Oct 22, 2013

Owner

new v2 supports Rails4

Owner

apneadiving commented Oct 22, 2013

new v2 supports Rails4

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Oct 22, 2013

awesome! :)

GantMan commented Oct 22, 2013

awesome! :)

@apneadiving

This comment has been minimized.

Show comment
Hide comment
@apneadiving

apneadiving Oct 22, 2013

Owner

Nice it pleases you :)

Beware though, th whole logic has changed too!

Owner

apneadiving commented Oct 22, 2013

Nice it pleases you :)

Beware though, th whole logic has changed too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment