Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

fixes from RT and version bump

  • Loading branch information...
commit 0db37ef7bb98a0cad6d7ed46d392da168b067f35 1 parent 04c2639
Apocalypse authored
View
6 Changes
@@ -1,5 +1,11 @@
Revision history for Perl extension POE::Component::SimpleDBI.
+* 1.27
+
+ Fixed RT#43408 ( fix "Modification of a read-only value attempted at" error at shutdown ) - thanks acferen!
+ Fixed RT#43442 ( tweak binmode for MSWin32 ) - thanks acferen!
+ Added link to the github.com repository in the POD
+
* 1.26
Kwalitee-related fixes ( moved to Test::Apocalypse )
View
12 lib/POE/Component/SimpleDBI.pm
@@ -4,7 +4,7 @@ use strict; use warnings;
# Initialize our version
use vars qw( $VERSION );
-$VERSION = '1.26';
+$VERSION = '1.27';
# Import what we need from the POE namespace
use POE; # For the constants
@@ -835,7 +835,7 @@ sub Clear_Queue {
}
# Go over our queue, and do some stuff
- foreach my $queue ( shift @{ $_[HEAP]->{'QUEUE'} } ) {
+ foreach my $queue ( @{ $_[HEAP]->{'QUEUE'} } ) {
# Skip the special EXIT actions we might have put on the queue
if ( $queue->{'ACTION'} eq 'EXIT' ) { next }
@@ -1983,6 +1983,14 @@ Please report any bugs or feature requests to C<bug-poe-component-simpledbi at r
the web interface at L<http://rt.cpan.org/NoAuth/ReportBug.html?Queue=POE-Component-SimpleDBI>. I will be
notified, and then you'll automatically be notified of progress on your bug as I make changes.
+=head2 Code Repository
+
+This code is currently hosted on github.com under the account "apocalypse". Please feel free to browse it
+and pull from it, or whatever. If you want to contribute patches, please send me a diff or prod me to pull
+from your repository :)
+
+L<http://github.com/apocalypse/perl-poe-simpledbi/tree/master>
+
=head1 AUTHOR
Apocalypse E<lt>apocal@cpan.orgE<gt>
View
16 lib/POE/Component/SimpleDBI/SubProcess.pm
@@ -4,7 +4,7 @@ use strict; use warnings;
# Initialize our version
use vars qw( $VERSION );
-$VERSION = '1.26';
+$VERSION = '1.27';
# Use Error.pm's try/catch semantics
use Error qw( :try );
@@ -24,18 +24,18 @@ my $DB = undef;
# Save the connect struct for future use
my $CONN = undef;
-# Autoflush to avoid weirdness
-$|++;
-
# Sysread error hits
my $sysreaderr = 0;
-# Set the binmode stuff
-binmode( STDIN );
-binmode( STDOUT );
-
# This is the subroutine that will get executed upon the fork() call by our parent
sub main {
+ # Autoflush to avoid weirdness
+ $|++;
+
+ # set binmode, thanks RT #43442
+ binmode( STDIN );
+ binmode( STDOUT );
+
# Okay, now we listen for commands from our parent :)
while ( sysread( STDIN, my $buffer = '', 1024 ) ) {
# Feed the line into the filter
Please sign in to comment.
Something went wrong with that request. Please try again.