New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lhare #1

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@lharey

lharey commented Jan 22, 2015

Hi

I don't know if you have heard about Neil Bowers CPAN Pull request challenge but I am having a go at it and have been assigned this module.

Although I've been writing perl for several years I have never contributed myself to CPAN before which is why I have decided to try the challenge.

There didn't seem much I could do with your module. So I've just made it pass level 4 perl critic severity. I've also added in some tests but I'm not sure how useful those tests are.

I'd welcome your feedback

Kind Regards
Lisa

lharey added some commits Jan 22, 2015

make pass perl critic level 5
fix policy RequireUseStrict
make pass perl critic severity 4
fix policy Subroutines::RequireArgUnpacking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment