Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Catalyst support #97

Open
bennypowers opened this issue Nov 25, 2020 · 2 comments
Open

[feature] Catalyst support #97

bennypowers opened this issue Nov 25, 2020 · 2 comments

Comments

@bennypowers
Copy link
Member

I bet apollo elements support for GitHub's new hotness would be cool

https://github.github.io/catalyst/guide/introduction/

at the very least, probably some mixins and a decorator or two? maybe a base class?

OTOH, is there a more idiomatic way than subclassing?

@keithamus
Copy link

Thanks for drawing my attention to this @bennypowers! Catalyst is a library on top of Web Components so it can leverage the base components you already have in this repository. I don't think there is any need for Catalyst specific versions 🎉

@bennypowers
Copy link
Member Author

👋 Thanks for the feedback @keithamus. It's a nice argument in support of both the web components primitives and your library that they can come together without fuss.

I sneakily released some base classes a few versions back, which just apply the mixins to vanilla HTMLElement. That being the case, and in light of your feedback, perhaps it will be enough to just document using catalyst with some examples on the docs page.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants