Skip to content

Florian Apolloner
apollo13

Organizations

@django @inyokaproject @rocketDuck
Jun 19, 2016
apollo13 commented on pull request django/django#6805
@apollo13

Maybe also assign to request.resolver_match in the same line (if it works with the line limit)

Jun 19, 2016
apollo13 commented on pull request django/django#6805
@apollo13

Looks good so far! 👍

Jun 13, 2016
Jun 13, 2016
apollo13 commented on pull request django/django#6726
@apollo13

I'd appreciate if changes like this would be left out in the future of feature patches to make them easier to review.

Jun 13, 2016
apollo13 commented on pull request django/django#6618
@apollo13

On Mon, Jun 13, 2016, at 09:40 AM, Carl Meyer wrote: @apollo13 Yep you probably did suggest it in IRC or on the mailing list - sorry for forgettin…

Jun 13, 2016
apollo13 commented on pull request django/django#6618
@apollo13

Fine with me, I just think APIs (that is, str.join is a perfect, but func(something, *something_else) is somewhat weird) like that look odd -- no b…

Jun 13, 2016
apollo13 commented on pull request django/django#6618
@apollo13

Jay, so back to one of my initial suggestions :D -- fwiw I am not sure that *-args are the best option here, either a single Exception or a list se…

Jun 10, 2016
apollo13 commented on pull request ibmdb/python-ibmdb#209
@apollo13

That would do it too, as long as the standard python expectations for exceptions are followed I do not care…

Jun 10, 2016
apollo13 commented on pull request django/django#6618
@apollo13

Regarding your inline comments: Yes, the new middleware behaves differently and if you want a chance at handling exceptions, you need to be wrapped…

Jun 10, 2016
apollo13 commented on pull request django/django#6618
@apollo13

We do not need to be backwards compatible do we? We just need a deprecation period where we allow for both forms -- the new system reacts different…

Jun 10, 2016
@apollo13

Indeed :)

Jun 3, 2016
@apollo13
  • @apollo13 b9bd707
    Set HSTS on nginx directly (covers trac too…)
Jun 3, 2016
@apollo13
  • @apollo13 6205617
    Use SAMEORIGIN instead of DENY in X-Frame-Options for docs (svg etc)
Jun 3, 2016
apollo13 commented on pull request django/django-localflavor#237
@apollo13

Done

May 31, 2016
@apollo13
  • @apollo13 d4ad28d
    [1.8.x] Fixed a typo in the docs.
May 31, 2016
@apollo13
  • @apollo13 1f7ab35
    [1.9.x] Fixed a typo in the docs.
May 31, 2016
@apollo13
  • @apollo13 62e4f8e
    Fixed a typo in the docs.
May 31, 2016
@apollo13
Channels is not calling HttpResponse.close()
May 23, 2016
apollo13 commented on issue credativ/informix_fdw#11
@apollo13

Tells you how much I am involved with PG development :D

May 22, 2016
apollo13 opened pull request python/pypi-salt#49
@apollo13
Added myself to psf-admins.
1 commit with 5 additions and 0 deletions
May 22, 2016
May 21, 2016
apollo13 commented on pull request django/django#6618
@apollo13

Yeah, backwards compat wise option 3 is probably the best choice.

May 20, 2016
apollo13 commented on issue credativ/informix_fdw#11
@apollo13

The changes seem to work nicely for me, all of my examples are pushed down properly. During testing I noted that IN-clauses are not pushed down, bu…

May 20, 2016
apollo13 commented on issue credativ/informix_fdw#11
@apollo13

Thanks, I'll see that I can test it. Regarding your commit message: I did not mean to gripe, I merely wanted to provide more background and help in…

May 20, 2016
apollo13 commented on pull request django/django#6618
@apollo13

Making that in BaseHandler is a bad idea, since not all middlewares need exceptions transformed, an ExceptionLoggingMiddleware and TransactionMiddl…

May 18, 2016
apollo13 commented on pull request django/django#6618
@apollo13

If we start inheriting from ExceptionMiddleware like that we should kill the handler argument to it, cause realistically speaking you can no longer…

May 18, 2016
apollo13 commented on pull request django/django#6618
@apollo13

Personally I think we might wanna at ExceptionMiddleware to the end of the middleware list if it is not in there -- this way all middlewares can as…

May 14, 2016
apollo13 commented on issue pypa/warehouse#61
@apollo13

The last release from velruse was in 2013 -- does not seem to be really reassuring. If there are no objections from @dstufft I'd give authomatic a …

Something went wrong with that request. Please try again.