Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke afterware after any kind of response. #1351

Merged

Conversation

@pseudoramble
Copy link
Contributor

pseudoramble commented Mar 2, 2017

Aims to address #1303. Invokes the afterware in the case that an HTTP response is not considered OK.

Once the afterware have been invoked, an error is thrown by the batchedNetworkInterface. If an error is thrown in one of the afterware then that error will be propagated instead.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
@helfer

This comment has been minimized.

Copy link
Member

helfer commented Mar 3, 2017

Thanks @pseudoramble! This looks good to me, but it's a potentially breaking change, so I'll merge it after the next minor release.

@helfer

This comment has been minimized.

Copy link
Member

helfer commented Mar 5, 2017

@pseudoramble btw, we have a checklist for a reason. I just noticed that there's no changelog entry 😉

@helfer helfer merged commit 9e8662c into apollographql:master Mar 5, 2017
3 checks passed
3 checks passed
CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 96.209%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.