New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isEqual should not fail if objects don't have proto #2138

Merged
merged 3 commits into from Sep 11, 2017

Conversation

Projects
None yet
3 participants
@slorber
Contributor

slorber commented Sep 11, 2017

Fixes #2132

@meteor-bot

This comment has been minimized.

meteor-bot commented Sep 11, 2017

@slorber: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@meteor-bot

This comment has been minimized.

meteor-bot commented Sep 11, 2017

Messages
📖

Please add your name and email to the AUTHORS file (optional)

📖

If this was a change that affects the external API, please update the docs and post a link to the PR in the discussion

Generated by 🚫 dangerJS

@jbaxleyiii

This comment has been minimized.

Member

jbaxleyiii commented Sep 11, 2017

@slorber nice! Thank you!

@jbaxleyiii jbaxleyiii merged commit 7711b19 into apollographql:master Sep 11, 2017

6 checks passed

CLA Author has signed the Meteor CLA.
Details
Danger All green. Good on 'ya.
Details
bundlesize ./dist/index.min.js: 28.62kB < maxSize 30kB gzip (9B larger than master, careful!)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.531%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment