New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing zen-observable dependencies #2442

Merged
merged 4 commits into from Nov 1, 2017

Conversation

Projects
None yet
3 participants
@Esemesek
Copy link
Contributor

Esemesek commented Oct 31, 2017

  • Moved @types/zen-observable dependency to optionalDependencies in apollo-client
  • Added zen-observable as a dependency in apollo-client

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.
Fix for missing zen-observable dependencies
- Moved @types/zen-observable dependency to optionalDependencies in apollo-client
- Added zen-observable as a dependency in apollo-client
@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Oct 31, 2017

@Esemesek: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Oct 31, 2017

@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Oct 31, 2017

Messages
📖

Please add your name and email to the AUTHORS file (optional)

Generated by 🚫 dangerJS

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 31, 2017

Codecov Report

Merging #2442 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2442   +/-   ##
=======================================
  Coverage   86.04%   86.04%           
=======================================
  Files          36       36           
  Lines        2049     2049           
  Branches      490      490           
=======================================
  Hits         1763     1763           
  Misses        277      277           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa8cff...2d3f728. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 31, 2017

Codecov Report

Merging #2442 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2442   +/-   ##
=======================================
  Coverage   86.04%   86.04%           
=======================================
  Files          36       36           
  Lines        2049     2049           
  Branches      490      490           
=======================================
  Hits         1763     1763           
  Misses        277      277           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa8cff...2d3f728. Read the comment docs.

@jbaxleyiii jbaxleyiii merged commit cc0faa1 into apollographql:master Nov 1, 2017

6 checks passed

CLA Author has signed the Meteor CLA.
Details
Danger All green. Jolly good show.
Details
bundlesize Good job! bundle size < maxSize
Details
codecov/project 86.04% (target 83%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment