Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[#3030] Fix no-cache fetchPolicy returns null or undefined #3102
When using the
The query listener will then be passed this during
I've tested these changes locally and using
I have a related fix that I think needs to be split in two.
For some fetch policies,
I noticed what seems to happen is that query listener will call
referenced this pull request
Mar 1, 2018
I don't think the benchmark is accurate/relevant, there's another PR that ups the thresholds. This change increases performance in the no-cache scenarios. It's why I contributed it back!…
On Thu, Mar 22, 2018, 13:25 Evan Sosenko ***@***.***> wrote: Is the benchmark test the only thing holding this up? What additional action is needed to merge? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3102 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiaa2ACDiI5qqEej1ojUf7YUTWWkio2ks5tg-yfgaJpZM4SY0c4> .
Mar 23, 2018
13 of 14 checks passed
Specifically, I end up with:
// package.json "apollo-cache-inmemory": "1.2.1", "apollo-client": "2.3.1", "apollo-codegen": "0.19.1", "apollo-link": "1.2.2", "apollo-link-error": "1.0.9", "apollo-link-http": "1.5.4", "react-apollo": "2.1.4"
Thinking it'd be best to make a new issue and reference this PR, closed things won't get as much traction (the PR can't be reopened).…
On Wed, May 16, 2018, 12:18 Kristie Howard ***@***.***> wrote: Here is a reproduction, showing how the data is missing. https://codesandbox.io/s/4zmopq25o0 It also demonstrates different results when defaultOptions versus setting the fetchPolicy component prop is used — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3102 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiaax_SQYvIEtWyWai-mZ-zIt2z8P_Vks5tzF9sgaJpZM4SY0c4> .