Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename JSONSerialziation+Sorting.swift to JSONSerialization+Sorting.swift #1000

Merged
merged 2 commits into from Feb 5, 2020

Conversation

@koenpunt
Copy link
Contributor

koenpunt commented Feb 5, 2020

No description provided.

…wift
@designatednerd

This comment has been minimized.

Copy link
Collaborator

designatednerd commented Feb 5, 2020

@koenpunt I think you have to update the name in the .xcworkspace too

@koenpunt

This comment has been minimized.

Copy link
Contributor Author

koenpunt commented Feb 5, 2020

You're right. I'm used to having xcodegen managing my Xcode project. Updated!

Copy link
Collaborator

designatednerd left a comment

Thanks for fixing my typo!

@designatednerd designatednerd merged commit e897966 into apollographql:master Feb 5, 2020
12 checks passed
12 checks passed
CLA Author has signed the Apollo CLA.
Details
ci/circleci: Apollo iOS 12.4 Your tests passed on CircleCI!
Details
ci/circleci: Apollo iOS 13.3 Your tests passed on CircleCI!
Details
ci/circleci: Apollo macOS 10.15 Your tests passed on CircleCI!
Details
ci/circleci: Apollo tvOS 13.3 Your tests passed on CircleCI!
Details
ci/circleci: ApolloSQLite iOS 12.4 Your tests passed on CircleCI!
Details
ci/circleci: ApolloSQLite iOS 13.3 Your tests passed on CircleCI!
Details
ci/circleci: ApolloSQLite macOS 10.15 Your tests passed on CircleCI!
Details
ci/circleci: ApolloWebSocket iOS 12.4 Your tests passed on CircleCI!
Details
ci/circleci: ApolloWebSocket iOS 13.3 Your tests passed on CircleCI!
Details
ci/circleci: ApolloWebSocket macOS 10.15 Your tests passed on CircleCI!
Details
netlify/apollo-ios-docs/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.