Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get to Starscream's underlying SOCKS proxy property. #1108

Merged
merged 1 commit into from Mar 31, 2020

Conversation

designatednerd
Copy link
Contributor

Addresses #1104. Definitely glad I went this way - it's not just that you have to set it on the web socket, you have to set it on the underlying stream. Ouch.

Anyway that's all abstracted away now so yay.

@designatednerd
Copy link
Contributor Author

@KonstantinEfimenko Wanna take a look?

return socket.enableSOCKSProxy
}
set {
guard var socket = self.websocket as? SOCKSProxyable else {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be guard var as guard let wouldn't let me change enableSOCKSProxy since this protocol is not class-bound.

@KonstantinEfimenko
Copy link

Looks good. Thank you!

@designatednerd designatednerd merged commit 9a1ecc0 into master Mar 31, 2020
@designatednerd designatednerd deleted the add/websocket-property branch March 31, 2020 17:09
@designatednerd designatednerd added this to the 0.25.0 milestone Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants