Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove Public Promise #709
NOTE: Leaving this as a draft because I'd like @martijnwalraven to take a look at this when he's back from vacation, and I'd love to hear any other feedback in the meantime.
This PR addresses #382. The promises Martijn created were originally intended to only be for framework-internal consumption, not for use by outside apps or SDKs. This is why we're using a custom
For this PR, we're only removing the "public" aspect of promises and continuing to use them under the hood. This should give us more flexibility in the future, and make it easier to wrap these methods in their preferred promise library.
Note that this is going to be a BREAKING CHANGE!
martijnwalraven left a comment
Glad to get rid of the publicly exposed
I think the code could be simplified with generic wrapper methods to convert methods from/to the use of promises, but that's probably not worth the trouble.