Skip to content

Commit

Permalink
allow setting engine: false to ignore env var
Browse files Browse the repository at this point in the history
  • Loading branch information
cheapsteak committed Jun 14, 2019
1 parent b635f17 commit 2e60f4f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/apollo-server-core/src/ApolloServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,13 @@ const NoIntrospection = (context: ValidationContext) => ({

function getEngineApiKey(engine: Config['engine']): string | undefined {
const keyFromEnv = process.env.ENGINE_API_KEY || '';
if (typeof engine === 'object' && engine.apiKey) {
if (engine === false) {
return;
} else if (typeof engine === 'object' && engine.apiKey) {
return engine.apiKey;
} else if (keyFromEnv) {
return keyFromEnv;
}
return;
}

function getEngineServiceId(engine: Config['engine']): string | undefined {
Expand Down

0 comments on commit 2e60f4f

Please sign in to comment.