Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'graphql-tag' module in 2.0.0-beta.5 #1152

Closed
loicplaire opened this issue Jun 7, 2018 · 11 comments
Milestone

Comments

@loicplaire
Copy link

@loicplaire loicplaire commented Jun 7, 2018

I believe I found an issue in the latest beta (2.0.0-beta.5).

How to reproduce

  1. Checkout https://github.com/apollographql/graphql-server-example.
  2. Run npm i and node index.js.
  3. You should get the following error:
module.js:549
    throw err;
    ^

Error: Cannot find module 'graphql-tag'
    at Function.Module._resolveFilename (module.js:547:15)
    at Function.Module._load (module.js:474:25)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/git/graphql-server-example/node_modules/apollo-server/node_modules/apollo-server-core/dist/index.js:25:21)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
@eugene1g

This comment has been minimized.

Copy link

@eugene1g eugene1g commented Jun 8, 2018

Pinging @evans as this bricks the release :)

A temp workaround is to install the dependency directly e.g. yarn add graphql-tag

@rashthedude

This comment has been minimized.

Copy link

@rashthedude rashthedude commented Jun 12, 2018

Encountered the same exact problem.

@Ken123777

This comment has been minimized.

Copy link

@Ken123777 Ken123777 commented Jun 12, 2018

Same problem for me too

@rookiedz

This comment has been minimized.

Copy link

@rookiedz rookiedz commented Jun 12, 2018

Same problem.

abernix referenced this issue Jun 12, 2018
@rodrigooler

This comment has been minimized.

Copy link

@rodrigooler rodrigooler commented Jun 12, 2018

Same problem.

@sachinrajgire

This comment has been minimized.

Copy link

@sachinrajgire sachinrajgire commented Jun 12, 2018

Just add
npm install --save graphql-tag
It resolved my issue

@rashthedude

This comment has been minimized.

Copy link

@rashthedude rashthedude commented Jun 12, 2018

@sachinrajgire it does but I reckon the underlying missing package should be added by apollo-server.

@rodrigooler

This comment has been minimized.

Copy link

@rodrigooler rodrigooler commented Jun 13, 2018

So @sachinrajgire, the correct would be the apollo-server contain this lib and I do not add it after hitting on an error for lack of adding dependencies.

@evans

This comment has been minimized.

Copy link
Member

@evans evans commented Jun 13, 2018

Sorry about that! 83c866e will be in the next release in a couple of hours

@Ken123777

This comment has been minimized.

Copy link

@Ken123777 Ken123777 commented Jun 13, 2018

Thanks @evans

@evans evans added this to the Release 2.0 milestone Jun 13, 2018
@evans

This comment has been minimized.

Copy link
Member

@evans evans commented Jun 13, 2018

We just published 2.0.0-beta.9, which includes graphql-tag ad a dependency

@evans evans closed this Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.