Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fastify #626

Closed
ghost opened this issue Oct 18, 2017 · 5 comments · Fixed by #1013 or #2280
Closed

Support fastify #626

ghost opened this issue Oct 18, 2017 · 5 comments · Fixed by #1013 or #2280

Comments

@ghost
Copy link

ghost commented Oct 18, 2017

Hi everyone! In respect to your contributing guidelines, I wanted to see if a consensus needed to be reached. Fastify has been picking up traction with 3k stars and 7k downloads this month. I'm using the fastify-apollo plugin I made in production and am loving it. To advocate, it's easy to implement routing and separate concerns outside of the graphql endpoint. Also fastify/fastify#302 brought up the issue of not enough visibility.

I got a good response in the Slack channel submit a PR but wanted to do my due diligence first.
@martijnwalraven
Copy link
Contributor

Thanks for opening an issue! We'd be happy to include aapollo-server-fastify package based on fastify-apollo.

My only concern would be that we'd really prefer all packages in this repo to be written in TypeScript, because that makes testing and releasing things together a lot easier.

@ghost
Copy link
Author

ghost commented Oct 18, 2017

My only concern would be that we'd really prefer all packages in this repo to be written in TypeScript, because that makes testing and releasing things together a lot easier.

Not a problem

I am also thinking not to include fastify-plugin in this iteration. Since each instance of fastify is scoped, the plugin just overrides that. But routes are not scoped...so it doesn't matter and one less dependency.

@lednhatkhanh
Copy link

It's really a good idea, I search for fastify and apollo integration right after I tried it for the first time. Hope that we can have an Apollo + fastify package soon!

@ghost ghost mentioned this issue Nov 2, 2017
Closed
5 tasks
@jeromemacias jeromemacias mentioned this issue Feb 6, 2018
Open
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Apr 30, 2018
@addityasingh
apollographql#626 Integrate apollo-fastify plugin
949d6d5
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Apr 30, 2018
@addityasingh
apollographql#626 Fix typescript issues
79c3051
addityasingh pushed a commit to addityasingh/apollo-server that referenced this issue Apr 30, 2018
@addityasingh
Integrate apollo-fastify plugin apollographql#626
d1f7d96
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Apr 30, 2018
@addityasingh
apollographql#626 Fix typescript issues
73cd6f2
@addityasingh addityasingh mentioned this issue Apr 30, 2018
Merged
4 tasks
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Apr 30, 2018
@addityasingh
apollographql#626 Update changelog
c8ec07e
addityasingh added a commit to addityasingh/apollo-server that referenced this issue May 1, 2018
@addityasingh
apollographql#626 Update README
dc8b4aa
addityasingh added a commit to addityasingh/apollo-server that referenced this issue May 1, 2018
@addityasingh
apollographql#626 Fix the breaking tests
5169229
addityasingh added a commit to addityasingh/apollo-server that referenced this issue May 16, 2018
@addityasingh
apollographql#626 Fix code review comments
b48d08a
addityasingh added a commit to addityasingh/apollo-server that referenced this issue May 16, 2018
@addityasingh
apollographql#626 Run Hapi tests only for node 8 and 9
e91e015
addityasingh added a commit to addityasingh/apollo-server that referenced this issue May 16, 2018
@addityasingh
apollographql#626 Run Hapi tests only for node 8 and 9
57589bb
addityasingh added a commit to addityasingh/apollo-server that referenced this issue May 16, 2018
@addityasingh
apollographql#626 Commit package.lock in working state
530bce1
addityasingh added a commit to addityasingh/apollo-server that referenced this issue May 16, 2018
@addityasingh
apollographql#626 Use npm instead of yarn for node 4
79a27d1
addityasingh added a commit to addityasingh/apollo-server that referenced this issue May 23, 2018
@addityasingh
apollographql#626 Bump the version
71b2a2f
evans pushed a commit that referenced this issue Jul 13, 2018
@addityasingh @evans
feat(fastify): Integrate apollo-fastify plugin (#1013)
8d5baec 
* Integrate apollo-fastify plugin #626

* #626 Fix typescript issues

* #626 Update changelog

* #626 Update README

* #626 Fix the breaking tests

* #626 Fix code review comments

* #626 Run Hapi tests only for node 8 and 9

* #626 Run Hapi tests only for node 8 and 9

* #626 Commit package.lock in working state

* #626 Use npm instead of yarn for node 4

* Revert package-lock and circle ci test job steps

* #626 Bump the version
evans added a commit that referenced this issue Jul 13, 2018
@evans
Merge master (#1347)
ee37d0c 
* chore(deps): update dependency @adonisjs/bodyparser to v2.0.3

* docs: Fix typo in lambda package README (#999)

* chore(deps): update dependency @types/aws-lambda to v8.10.3

* chore(deps): update dependency @types/node to v9.6.7

* chore(deps): update dependency koa to v2.5.1

* chore(deps): update dependency hapi to v17.4.0 (#1009)

* chore(deps): update dependency sinon to v5 (#1010)

* chore(deps): update dependency @types/node to v9.6.8

* chore(deps): update dependency sinon to v5.0.2

* Temporarily remove version 2.

* Update meteor-theme-hexo to 1.0.9.

* chore(deps): update dependency sinon to v5.0.3

* chore(deps): update dependency @types/node to v9.6.9

* Revert "Temporarily remove version 2."

This reverts commit 6f50769.

* Update package.json's hexo.version to 3.7.1.

* chore(deps): update dependency @types/node to v9.6.11

* chore(deps): update dependency @types/node to v9.6.12

* chore(deps): update dependency hexo-server to v0.3.2

* chore(deps): update dependency sinon to v5.0.5

* chore(deps): update dependency sinon to v5.0.6

* chore(deps): update dependency sinon to v5.0.7

* chore(deps): update dependency @types/node to v9.6.14

* chore(deps): update dependency @types/sinon to v4.3.2

* bump version of subscriptions-transport-ws for graphiql

The newer subscription client has a more forgiving default ka timeout

* chore(deps): update dependency @types/node to v9.6.15

* chore(deps): update dependency @types/sinon to v4.3.3

* Fix typos in setup.md

* fix graphiql docs for hapi

* tests: Stop testing Node.js 4, which has reached the end of its LTS. (#1026)

Node.js 4 will no longer be receiving any additional updates from the
Node.js foundation, as per the expected LTS schedule[0] and their blog post:

https://medium.com/the-node-js-collection/april-2018-release-updates-from-the-node-js-project-71687e1f7742

[0]: https://github.com/nodejs/LTS

* chore(deps): update dependency @types/node to v9.6.18

* chore(deps): update dependency @types/aws-lambda to v8.10.4

* chore(deps): update dependency @types/restify to v5.0.8

* chore(deps): update dependency body-parser to v1.18.3

* chore(deps): update dependency koa-bodyparser to v4.2.1

* chore(deps): update dependency mocha to v5.2.0

* chore(deps): update dependency supertest to v3.1.0

* chore(deps): update dependency hapi to v17.5.0

* docs: add pointer to apollo server 2 documentation (#1083)

* chore(deps): update dependency meteor-theme-hexo to v1.0.10

* chore(deps): update dependency @types/aws-lambda to v8.10.5

* chore(deps): update dependency sinon to v5.0.9

* chore(deps): update dependency sinon to v5.0.10

* chore(deps): update dependency @types/node to v9.6.19

* chore(deps): update dependency hapi to v17.5.1

* chore(deps): update dependency typescript to v2.8.4

* chore(deps): update dependency meteor-theme-hexo to v1.0.13 (#1118)

* chore(deps): update dependency @types/aws-lambda to v8.10.6

* chore(deps): update dependency @types/node to v9.6.20

* koa: remove dist names from readme example (#1122)

Since koa@2 has been published for a long time, and almost all the middlewares migrated to koa@2.
It's no need to add extra dist names for koa and koa middlewares.

* chore(deps): update dependency @types/koa to v2.0.46

* chore(deps): update dependency @types/mocha to v5.2.1

* chore(deps): update dependency @types/restify to v5.0.9

* chore(deps): update dependency @types/express to v4.16.0

* chore(deps): update dependency sinon to v5.1.0

* chore(deps): update dependency @types/node to v9.6.21

* chore(deps): update dependency sinon to v5.1.1

* docs: Add/update documentation README.md.

In order to provide a more universal README.md across all documentation
deployment repositories, and most importantly, to reference the so-called
"documentation for the documentation".

* chore(deps): update dependency meteor-theme-hexo to v1.0.14 (#1199)

This Pull Request updates dependency [meteor-theme-hexo](https://github.com/meteor/meteor-theme-hexo) from `v1.0.13` to `v1.0.14`

**Note**: This PR was created on a configured schedule ("after 10pm every weekday,before 5am every weekday" in timezone `America/Los_Angeles`) and will not receive updates outside those times.


<details>
<summary>Release Notes</summary>

### [`v1.0.14`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1014)
[Compare Source](meteor/meteor-theme-hexo@v1.0.13...v1.0.14)
* Allow the "Edit on GitHub" button to work on "versioned" documentation.
  [PR #&#8203;80](`https://github.com/meteor/meteor-theme-hexo/pull/80`)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

* Update renovate.json

* Update renovate.json

Hopefully these additional hours and the offset won't be problematic for anyone, but they should help me out some.

We'll see!

* Update renovate.json

* chore(deps): pin dependency hexo-versioned-netlify-redirects to v1.0.7 (#1203)

This Pull Request updates dependency `hexo-versioned-netlify-redirects` from `^1.0.7` to `v1.0.7`



---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

* chore(deps): update dependency @types/chai to v4.1.4

* chore(deps): update dependency @types/koa-router to v7.0.29

* chore(deps): update dependency @types/mocha to v5.2.3

* chore(deps): update dependency @types/multer to v1.3.7

* chore(deps): update dependency @types/node to v9.6.22

* chore(deps): update dependency meteor-theme-hexo to v1.0.15

* chore(deps): update dependency @types/koa-router to v7.0.30

* chore(deps): update dependency @types/aws-lambda to v8.10.7

* chore(deps): update dependency hapi to v17.5.2

* Use apollo-server v1 in example relating to v1

* docs: Add sentence punctuation to 2.0 callout.

Follows-up on #1083.

* chore(deps): update dependency meteor-theme-hexo to v1.0.16 (#1262)

This Pull Request updates dependency [meteor-theme-hexo](https://github.com/meteor/meteor-theme-hexo) from `v1.0.15` to `v1.0.16`



<details>
<summary>Release Notes</summary>

### [`v1.0.16`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1016)
[Compare Source](meteor/meteor-theme-hexo@v1.0.15...v1.0.16)
* Re-introduce the scrolling ability within search results.
  [PR #&#8203;83](`https://github.com/meteor/meteor-theme-hexo/pull/83`)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

* chore(deps): update dependency @types/mocha to v5.2.4

* chore(deps): update dependency multer to v1.3.1

* chore(deps): update dependency @types/node to v9.6.23

* chore(deps): update dependency apollo-hexo-config to v1.0.8 (#1329)

This Pull Request updates dependency [apollo-hexo-config](https://github.com/apollographql/apollo-hexo-config) from `v1.0.7` to `v1.0.8`



<details>
<summary>Release Notes</summary>

### [`v1.0.8`](https://github.com/apollographql/apollo-hexo-config/compare/v1.0.7...v1.0.8)
[Compare Source](https://github.com/apollographql/apollo-hexo-config/compare/v1.0.7...v1.0.8)


---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

* docs: Add browser auto-reloading on source content changes. (#1336)

By virtue of a relatively simple `hexo-browsersync` package[0], which
implements BrowserSync[1] in Hexo, this change brings support for automatically
reloading the browser when the source content has changed.

No more pressing "Reload" in order to see the changes to the Markdown source
when working on documentation! 🎉

[0]: https://npm.im/hexo-browsersync
[1]: https://www.browsersync.io

* chore(deps): update dependency koa to v2.5.2

* docs: add note about passing context as a function (#757)

* docs: add note about passing context as a function

We realized today (by mistake) that the value of `context` in `GraphQLOptions` can be a function. Adding a note to the docs so it doesn't surprise anyone else.

* docs: update context as a function docs

- fix description per @n1ru4l's feedback
- add a code example of instantiating a new class in the context for each request

* Added option to disable rewriting URL for GraphiQL (#1047)

* added option to disable rewriting url for graphiql

* updated docs

* added link to PR in changelog

* Add skipValidation option. (#839)

* Don't validate if query is already an AST.

* Skip validation option.

* fix(hapi16_support): add hapi 16 next() invocation [closes #744] (#743)

* chore(hapi16_support): add hapi 16 next() invocation

* run lint fix

* update changelog

* feat(fastify): Integrate apollo-fastify plugin (#1013)

* Integrate apollo-fastify plugin #626

* #626 Fix typescript issues

* #626 Update changelog

* #626 Update README

* #626 Fix the breaking tests

* #626 Fix code review comments

* #626 Run Hapi tests only for node 8 and 9

* #626 Run Hapi tests only for node 8 and 9

* #626 Commit package.lock in working state

* #626 Use npm instead of yarn for node 4

* Revert package-lock and circle ci test job steps

* #626 Bump the version

* v1.4.0

* bring version-2 up to date

* remove apollo-server-fastify

* fix export of hapi middleware

* remove setup

* fix hapi readme

* remove unused tests
@cpenarrieta cpenarrieta mentioned this issue Jul 18, 2018
Closed
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Oct 2, 2018
@addityasingh
feat(fastify): Integrate apollo-fastify plugin apollographql#626
23b5b32
@addityasingh addityasingh mentioned this issue Oct 3, 2018
Closed
3 tasks
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Oct 3, 2018
@addityasingh
feat(fastify): Fix review comments and broken tests, build apollograp…
f004237 
…hql#626
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Oct 3, 2018
@addityasingh
feat(fastify): Fix test apollographql#626
69b619b
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Oct 3, 2018
@addityasingh
feat(fastify): Remove local package apollographql#626
aebbcf2
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Oct 3, 2018
@addityasingh
feat(fastify): Add fastify package to workspace apollographql#626
dd432e7
addityasingh added a commit to addityasingh/apollo-server that referenced this issue Oct 7, 2018
@addityasingh
feat(fastify): Update package lock apollographql#626
4f5509d
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 19, 2018
@rkorrelboom
feat(fastify) Update README's with fastify createHandler interface ap…
64df05d 
…ollographql#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 19, 2018
@rkorrelboom
feat(fastify) Implement the fastify createHandler as a synchronous me…
ce92aed 
…thod apollographql#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 21, 2018
@rkorrelboom
feat(fastify) Apollo Fastify server integration resolve apollographql…
eaac6d2 
…#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 21, 2018
@rkorrelboom
feat(fastify) Use createHandler instead of applyMiddleware apollograp…
b08a8bf 
…hql#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 21, 2018
@rkorrelboom
feat(fastify) Fix integration test for node 10 apollographql#626
d4192c1
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 21, 2018
@rkorrelboom
feat(fastify) Update README's with fastify createHandler interface ap…
56acc0b 
…ollographql#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 21, 2018
@rkorrelboom
feat(fastify) Implement the fastify createHandler as a synchronous me…
ef3a3a4 
…thod apollographql#626
@tomByrer
Copy link

What's the status of this please?

rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 22, 2018
@rkorrelboom
feat(fastify) Apollo Fastify server integration resolve apollographql…
6fc502b 
…#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 22, 2018
@rkorrelboom
feat(fastify) Use createHandler instead of applyMiddleware apollograp…
56d513d 
…hql#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 22, 2018
@rkorrelboom
feat(fastify) Fix integration test for node 10 apollographql#626
6d3dc26
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 22, 2018
@rkorrelboom
feat(fastify) Update README's with fastify createHandler interface ap…
fb8bd2a 
…ollographql#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 22, 2018
@rkorrelboom
feat(fastify) Implement the fastify createHandler as a synchronous me…
6381c47 
…thod apollographql#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 28, 2018
@rkorrelboom
feat(fastify) Apollo Fastify server integration resolve apollographql…
5c237cc 
…#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 28, 2018
@rkorrelboom
feat(fastify) Use createHandler instead of applyMiddleware apollograp…
97746f8 
…hql#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 28, 2018
@rkorrelboom
feat(fastify) Fix integration test for node 10 apollographql#626
0ff54e9
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 28, 2018
@rkorrelboom
feat(fastify) Update README's with fastify createHandler interface ap…
dd406c9 
…ollographql#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Nov 28, 2018
@rkorrelboom
feat(fastify) Implement the fastify createHandler as a synchronous me…
f770373 
…thod apollographql#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Jan 2, 2019
@rkorrelboom
feat(fastify) Apollo Fastify server integration resolve apollographql…
bacdeae 
…#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Jan 2, 2019
@rkorrelboom
feat(fastify) Use createHandler instead of applyMiddleware apollograp…
a1d2b74 
…hql#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Jan 2, 2019
@rkorrelboom
feat(fastify) Fix integration test for node 10 apollographql#626
88ff161
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Jan 2, 2019
@rkorrelboom
feat(fastify) Update README's with fastify createHandler interface ap…
fb023a5 
…ollographql#626
rkorrelboom added a commit to rkorrelboom/apollo-server that referenced this issue Jan 2, 2019
@rkorrelboom
feat(fastify) Implement the fastify createHandler as a synchronous me…
482cdad 
…thod apollographql#626
abernix added a commit that referenced this issue Feb 7, 2019
@abernix
TEMP: Revert "feat(Fastify) Apollo server Fastify integration #626 (#…
b07569b 
…1971)"

This TEMPORARILY reverts commit 069110b,
which was the result of the work done in #1971 by @rkorrelboom.

Unfortunately, we need to put this on ice while we wait for movement on a
package naming conflict.  The dialog surrounding this is under way, as
I've explained in the PR:

#1971 (comment)

I'm excited to re-land this in an upcoming version, but there's no reason to
block the 2.4.0 release for it right now.

I will open a new PR with the work from #1971 in due time.
@abernix abernix reopened this Feb 7, 2019
abernix added a commit that referenced this issue Feb 7, 2019
@abernix
TEMP: Revert "feat(Fastify) Apollo server Fastify integration #626 (#…
e971bdf 
…1971)"

This TEMPORARILY reverts commit 069110b,
which was the result of the work done in #1971 by @rkorrelboom.

Unfortunately, we need to put this on ice while we wait for movement on a
package naming conflict.  The dialog surrounding this is under way, as
I've explained in the PR:

#1971 (comment)

I'm excited to re-land this in an upcoming version, but there's no reason to
block the 2.4.0 release for it right now.

I will open a new PR with the work from #1971 in due time.
@abernix abernix mentioned this issue Feb 7, 2019
Merged
@abernix abernix closed this as completed in 069110b Feb 7, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@martijnwalraven @abernix @tomByrer @lednhatkhanh