Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use usage reporting code from new utils package #6449

merged 4 commits into from May 20, 2022


Copy link

@trevor-scheer trevor-scheer commented May 19, 2022

Shared usage reporting code was moved to its own package in the utils repo since it's also used by the router bridge and has been copy/pasted across both projects for some time. This PR moves our usage over to the new common one.

Ref: apollographql/apollo-utils#92

Copy link

netlify bot commented May 19, 2022

Deploy Preview for apollo-server-docs canceled.

Name Link
🔨 Latest commit c914bd2
🔍 Latest deploy log

Copy link

codesandbox-ci bot commented May 19, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c914bd2:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

Copy link

@glasser glasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine but incomplete — how about the signature calculation code?

Copy link
Member Author

@glasser weird, whoops

@trevor-scheer trevor-scheer enabled auto-merge (squash) May 20, 2022 23:23
@trevor-scheer trevor-scheer merged commit 270d8c2 into main May 20, 2022
@trevor-scheer trevor-scheer deleted the trevor/usage-reporting-utils branch May 20, 2022 23:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants