Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support localSchemaFile flag to push to a service from local schema #710

Merged
merged 4 commits into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@trevor-scheer
Copy link
Member

trevor-scheer commented Nov 15, 2018

Pushing from a local schema was previously supported through the CLI via the --endpoint flag. We could continue to support that through some logic where we parse that flag but instead I've chosen to add a new flag that's more semantic and less magic.

This PR also allows client:codegen to point to a local schema from the CLI with the same flag.

  • Tested and successfully published with a local .gql schema using the --localSchemaFile flag.
  • Tested and successfully generated typescript types with a local .gql schema using the same flag.

Fixes #672

trevor-scheer added some commits Nov 15, 2018

Support localSchemaFile flag to push to a service from local schema
Pushing from a local schema was previously supported through the CLI via
the --endpoint flag. We could continue to support that through some logic
where we parse that flag but instead I've chosen to add a new flag that's
more semantic and less magic.
Show resolved Hide resolved packages/apollo/src/commands/client/codegen.ts Outdated
Show resolved Hide resolved packages/apollo/src/Command.ts
Show resolved Hide resolved packages/apollo/src/Command.ts
Cleanup
* Improve descriptions for localSchemaFile flag
* Clean up logic for setting defaults on the config
* Add Flags type in another spot

@trevor-scheer trevor-scheer force-pushed the trevor/fix-push-local-schema branch from 6ceadfa to a7557af Nov 16, 2018

@trevor-scheer trevor-scheer merged commit a0a26a1 into master Nov 16, 2018

6 checks passed

CLA Author has signed the Meteor CLA.
Details
apollo/client/check: engine-api-prod/current Client check successful
ci/circleci: Linting Your tests passed on CircleCI!
Details
ci/circleci: Node.js 10 Your tests passed on CircleCI!
Details
ci/circleci: Node.js 8 Your tests passed on CircleCI!
Details
ci/circleci: Query Check Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.