New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include/Exclude in the response? #5

Open
jasonbahl opened this Issue Sep 14, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@jasonbahl

jasonbahl commented Sep 14, 2017

Has there been any discussion on how the consumer can specify whether to include tracing in the response?

My initial thought for my implementation would be to check the request headers to see if tracing is being requested or not.

@jasonbahl

This comment has been minimized.

jasonbahl commented Sep 18, 2017

Would also be good to create a standard so tools like GraphiQL can integrate and send a header (or something to that tune) that asks to includeTracing.

The standard could be a header, or an addition to the request payload. . .like:

{
  operationName: 'queryWithTracing',
  query: 'query queryWithTracing { posts { edges { node { id } } } }',
  variables: {},
  extensions: {
     tracing: true
  }
}
@martijnwalraven

This comment has been minimized.

Contributor

martijnwalraven commented Sep 20, 2017

Yeah, I think it makes sense to add support for something like this. We may not want to depend on HTTP because people might be using alternative transports (such as WebSockets), but an extensions field as part of the request payload makes sense to me.

@Kosta-Github

This comment has been minimized.

Kosta-Github commented Sep 22, 2017

I am using something like this in my queries:

{
    RuntimeStatistics {
        IncludeURLs
        RequestTimings
    }
}

The corresponding resolvers having the side effect of injecting the requested statistics into the extension prop at the end of the query...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment