New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React@16 functions that return arrays will break SSR #1158

Closed
bkniffler opened this Issue Sep 27, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@bkniffler
Copy link

bkniffler commented Sep 27, 2017

Using something like

export default ({}) => [<Component1 key={1} />,<Component2 key={2} />/]

breaks the SSR since it doesn't expect arrays.

Valid since React@16 (https://facebook.github.io/react/blog/2017/09/26/react-v16.0.html)

PR here: #1157

@stale

This comment has been minimized.

Copy link

stale bot commented Oct 18, 2017

This issue has been automatically labled because it has not had recent activity. If you have not received a response from anyone, please mention the repository maintainer (most likely @jbaxleyiii). It will be closed if no further activity occurs. Thank you for your contributions to React Apollo!

@clayne11

This comment has been minimized.

Copy link
Contributor

clayne11 commented Oct 21, 2017

I added a PR with tests to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment