New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notifyOnNetworkStatusChange to QueryOpts and MutationOpts types #1034

merged 2 commits into from Aug 31, 2017


None yet
3 participants
Copy link

doomsower commented Aug 25, 2017

This small PR fixes issue #896 - notifyOnNetworkStatusChange were missing from Typescript definitions of query and mutation options.


This comment has been minimized.

Copy link

meteor-bot commented Aug 25, 2017


There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS


This comment has been minimized.

Copy link

jbaxleyiii commented Aug 31, 2017

Thank you @doomsower!

@jbaxleyiii jbaxleyiii merged commit cddfc99 into apollographql:master Aug 31, 2017

4 checks passed

CLA Author has signed the Meteor CLA.
Danger ⚠️ Danger found some issues. Don't worry, everything is fixable.
bundlesize ./dist/index.min.js: 11.96kB < maxSize 12kB gzip (same as master)
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment