New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to apollo client 0.4.0 #105

Merged
merged 4 commits into from Jul 12, 2016

Conversation

Projects
None yet
3 participants
@stubailo
Copy link
Member

stubailo commented Jul 12, 2016

A few hacks we should fixe before merging

stubailo added some commits Jul 12, 2016

WIP

@zol zol added the in progress label Jul 12, 2016

return false;
} else if (oldQueries) {
// unsubscribe from previous queries
this.unsubcribeAllQueries();
}

if (isObject(queryHandles) && Object.keys(queryHandles).length) {
this.queryHandles = queryHandles;

This comment has been minimized.

@stubailo

stubailo Jul 12, 2016

Author Member

As far as I know, this line was not correct - it was assigning query options to the same object we use to hold the observables/handles/subscriptions.

@@ -274,12 +274,13 @@ import { Observable, Observer, Subscription } from '~apollo-client/util/Observab
export class ObservableQuery extends Observable<GraphQLResult> {
subscribe(observer: Observer<GraphQLResult>): QuerySubscription;
result(): Promise<GraphQLResult>;
}
export interface QuerySubscription extends Subscription {

This comment has been minimized.

@stubailo

stubailo Jul 12, 2016

Author Member

I couldn't figure out how to get typings to do the right thing here, so I edited manually to get things to pass. How do we regenerate the types here?

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Jul 12, 2016

@stubailo thank you so much for doing this!

@stubailo stubailo changed the title [WIP] Update to apollo client 0.4.0 Update to apollo client 0.4.0 Jul 12, 2016

@stubailo

This comment has been minimized.

Copy link
Member Author

stubailo commented Jul 12, 2016

@jbaxleyiii I think it's ready to merge as soon as you have time to look it over!

@stubailo stubailo merged commit 57d280f into master Jul 12, 2016

4 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 96.825%
Details

@zol zol removed the in progress label Jul 12, 2016

@jbaxleyiii jbaxleyiii deleted the update-to-apollo-client-0.4.0 branch Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment