New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update query after changing ApiClient #1145

Merged
merged 2 commits into from Oct 15, 2017

Conversation

Projects
None yet
4 participants
@valerybugakov
Copy link

valerybugakov commented Sep 26, 2017

Using another ApiClient with graphql container and mutation causes running of this.updateQuery(nextProps); which should not be executed for mutation from my understanding.

Fixes already closed #812.

@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Sep 26, 2017

@valerybugakov: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Sep 26, 2017

@valerybugakov wonderful! Could you update the changelog and add a test for this?

valerybugakov added a commit to valerybugakov/react-apollo that referenced this pull request Sep 27, 2017

@valerybugakov valerybugakov force-pushed the valerybugakov:master branch from 0c1db2c to 21f3ba2 Sep 27, 2017

@valerybugakov

This comment has been minimized.

Copy link
Author

valerybugakov commented Sep 27, 2017

@jbaxleyiii added test case and rebased with master

@jbaxleyiii jbaxleyiii merged commit e6526f4 into apollographql:master Oct 15, 2017

4 checks passed

CLA Author has signed the Meteor CLA.
Details
Danger All green. Congrats.
Details
bundlesize ./dist/index.min.js: 11.96kB < maxSize 12kB gzip
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@flisky

This comment has been minimized.

Copy link

flisky commented Dec 21, 2017

We're bitten by this. Any chance we can land it in master and release it?

@flisky

This comment has been minimized.

Copy link

flisky commented Dec 26, 2017

ping again, @jbaxleyiii @valerybugakov. It was NOT merged to master, and could anyone confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment