New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redux from peer dependencies for v2 #1224

Merged
merged 2 commits into from Oct 15, 2017

Conversation

Projects
None yet
3 participants
@jaydenseric
Copy link
Contributor

jaydenseric commented Oct 11, 2017

Fixes #1223.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

@jaydenseric jaydenseric changed the title Removed redux from peer dependencies. Removed redux from peer dependencies for v2 Oct 11, 2017

@jbaxleyiii jbaxleyiii merged commit 37d432c into apollographql:apollo-client-2.0 Oct 15, 2017

4 checks passed

CLA Author has signed the Meteor CLA.
Details
Danger All green. Well done.
Details
bundlesize ./dist/index.min.js: 7.96kB < maxSize 8kB gzip
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -83,8 +83,7 @@
"license": "MIT",
"peerDependencies": {
"apollo-client": "^2.0.0-beta.3",
"react": "0.14.x || 15.* || ^15.0.0 || ^16.0.0",
"redux": "^2.0.0 || ^3.0.0"
"react": "0.14.x || 15.* || ^15.0.0 || ^16.0.0"

This comment has been minimized.

@stevemao

stevemao Nov 7, 2017

Is there any difference between 15.* and ^15.0.0?

This comment has been minimized.

@jaydenseric

jaydenseric Nov 7, 2017

Author Contributor

No difference, it looks redundant.

I think:

"react": "0.14.x || 15.* || ^15.0.0 || ^16.0.0"

Can be simplified to:

"react": "0.14 - 16"

@jaydenseric jaydenseric deleted the jaydenseric:remove-redux-peer-dependency branch Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment