New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate fetchMore #123

Merged
merged 8 commits into from Aug 2, 2016

Conversation

Projects
None yet
3 participants
@Slava
Copy link
Contributor

Slava commented Jul 29, 2016

This is a preliminary change, I didn't test it yet.

I might need more help from @stubailo and @jbaxleyiii. Specifically, I am not sure if we need to bind fetchMore the same way we bind refetch? I don't really understand all the intricacies of the react integration.

@Slava Slava added the in progress label Jul 29, 2016

@Slava

This comment has been minimized.

Copy link
Contributor Author

Slava commented Jul 29, 2016

I read more code and attempted to bind the fetchMore function to set a loadingMore property too.

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Jul 30, 2016

@Slava I should have the new api done by monday. Are you okay with me adding fetchMore in there instead of the old api?

@Slava

This comment has been minimized.

Copy link
Contributor Author

Slava commented Jul 31, 2016

Yes sure
2016년 7월 30일 (토) 오후 4:51, James Baxley notifications@github.com님이 작성:

@Slava https://github.com/Slava I should have the new api done by
monday. Are you okay with me adding fetchMore in there instead of the old
api?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#123 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACfNPjBpllrF0YhQSA9h3pbYHhyixHdfks5qa-NwgaJpZM4JXyy2
.

@jbaxleyiii jbaxleyiii merged commit 4ee77ba into master Aug 2, 2016

4 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 96.979%
Details

@jbaxleyiii jbaxleyiii deleted the fetch-more branch Aug 2, 2016

@zol zol removed the in progress label Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment