New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OptionProps.data's TResult partial #1231

Merged
merged 1 commit into from Oct 15, 2017

Conversation

Projects
None yet
3 participants
@leoasis
Copy link
Collaborator

leoasis commented Oct 11, 2017

This is a companion PR for #1143, which made the result fields partial in ChildProps. The same was needed in OptionProps, so I added it here.

@leoasis leoasis force-pushed the leoasis:partial_option_data_fields branch from d447a5c to bba962f Oct 11, 2017

@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Oct 11, 2017

Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

@jbaxleyiii jbaxleyiii merged commit 2a4533f into apollographql:master Oct 15, 2017

4 checks passed

CLA Author has signed the Meteor CLA.
Details
Danger ⚠️ Danger found some issues. Don't worry, everything is fixable.
Details
bundlesize ./dist/index.min.js: 11.95KB (same as master)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@leoasis leoasis deleted the leoasis:partial_option_data_fields branch Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment