New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-port #1181 to 2.0 #1330

Merged
merged 2 commits into from Nov 9, 2017

Conversation

Projects
None yet
4 participants
@glasser
Copy link
Contributor

glasser commented Nov 9, 2017

#1181 seems to have not made it to react-apollo 2.0. This PR cherry-picks the change and updates the test to 2.0.

@glasser glasser requested a review from peggyrayzis Nov 9, 2017

rhberro and others added some commits Oct 15, 2017

Skip should prevent options from call in componentWillReceiveProps
Identical to #1181 which didn't make it to 2.0.

Test fails because it uses networkInterface. Next commit will fix for 2.0 API.
@peggyrayzis
Copy link
Member

peggyrayzis left a comment

Thanks for catching this! 🎉

@jbaxleyiii jbaxleyiii merged commit a883178 into master Nov 9, 2017

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
CLA Author has signed the Meteor CLA.
Details
Danger All green. Well done.
Details
bundlesize ./dist/index.min.js: 8.46kB < maxSize 8.6kB gzip
Details

@jbaxleyiii jbaxleyiii deleted the glasser/forward-port-1181 branch Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment