New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated flow to 0.59.0 #1354

Merged
merged 15 commits into from Nov 29, 2017

Conversation

Projects
None yet
3 participants
@gforge
Copy link
Contributor

gforge commented Nov 24, 2017

In response to query in issue #1220: an update of the flow definitions that work with version 0.59.0 - also removed the npm flow-typed libraries as there seems to have been a typo in the .gitignore that allowed these to be added to the repository.

The remaining flow issues seem to stem from issues in the graphql-js library - this is due to the graphql being of < 0.11.7.

Checklist:

  • Make sure all of the significant new logic is covered by tests

gforge and others added some commits Aug 20, 2017

@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Nov 24, 2017

Warnings
⚠️

❗️ Big PR

Generated by 🚫 dangerJS

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Nov 29, 2017

@gforge thank you SO SO much for getting flow types going again! This all looks great to me, though I've fallen behind on my flow knowledge.

Would you be open to helping bring flow types back for apollo-client packages?

And are you on the Apollo slack? I'd love to say thanks!

@jbaxleyiii jbaxleyiii merged commit d4856a1 into apollographql:master Nov 29, 2017

4 checks passed

CLA Author has signed the Meteor CLA.
Details
Danger ⚠️ Danger found some issues. Don't worry, everything is fixable.
Details
bundlesize ./dist/index.min.js: 8.46kB < maxSize 8.6kB gzip
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gforge

This comment has been minimized.

Copy link
Contributor Author

gforge commented Nov 29, 2017

@jbaxleyiii great to hear that it was appreciated. I'm on the slack channel although I haven't been there that frequently.

Flow is changing at an incredible rate and it's hard to keep up with all the changes. Although this seems true for all packages - it seems almost impossible to have up-to-date dependenies...

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Nov 30, 2017

@gforge I've noticed the same 😢

TSMMark added a commit to TSMMark/react-apollo that referenced this pull request Dec 3, 2017

Remove flow-typed from deploy script
apollographql#1354 removed all flow-typed so there is no flow-typed directory anymore

jbaxleyiii pushed a commit that referenced this pull request Dec 8, 2017

Remove flow-typed from deploy script (#1376)
#1354 removed all flow-typed so there is no flow-typed directory anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment