New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add immutable support #137

Merged
merged 3 commits into from Aug 13, 2016

Conversation

Projects
None yet
3 participants
@jbaxleyiii
Copy link
Member

jbaxleyiii commented Aug 13, 2016

This add support for an immutable tree via

<ApolloProvider store={myImmutableStore} client={myClient} immutable={true}><App></ApolloProvider>

James Baxley

@zol zol added the in progress label Aug 13, 2016

James Baxley
James Baxley

@jbaxleyiii jbaxleyiii changed the title ensure it works with redux-loop Add immutable support Aug 13, 2016

@jbaxleyiii jbaxleyiii merged commit 58eb6d1 into master Aug 13, 2016

3 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jbaxleyiii jbaxleyiii deleted the redux-loop-example branch Aug 13, 2016

@zol zol removed the in progress label Aug 13, 2016

@@ -51,6 +53,8 @@ export default class ApolloProvider extends Component<ProviderProps, any> {

if (props.store) {
this.store = props.store;
// support an immutable store alongside apollo store
if (props.immutable) props.client.initStore();

This comment has been minimized.

@stubailo

stubailo Aug 16, 2016

Member

I feel like we wouldn't need this if we just had client.getStore() which initialized it for you before returning one? Or is there some other reason we need it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment