Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemoved the react-native test. #1451
Conversation
This comment has been minimized.
This comment has been minimized.
|
Note, this is WIP. I am completing this as soon as I find some more time. |
rosskevin
added
the
PR: on-hold
label
Dec 26, 2017
excitement-engineer
added some commits
Dec 26, 2017
This comment has been minimized.
This comment has been minimized.
|
I can confirm that the test What should we do with this test? It seems that this test has nothing to do with |
excitement-engineer
removed
the
PR: work-in-progress
label
Dec 27, 2017
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@excitement-engineer can you rebase - I'd like to get this one merged. |
rosskevin
approved these changes
Dec 27, 2017
| const globalAny: any = global; | ||
|
|
||
| globalAny.requestAnimationFrame = callback => { | ||
| setTimeout(callback, 0); |
This comment has been minimized.
This comment has been minimized.
rosskevin
Dec 27, 2017
Collaborator
This is the long way to type it, you could just do (global as any).requestAnimationFrame
This comment has been minimized.
This comment has been minimized.
|
It seems like the ci is not starting, maybe travis is down. The ci will not pass because of the broken test. Given that it seems to be testing something internal in apollo-client. Perhaps we should simply delete the test |
This comment has been minimized.
This comment has been minimized.
|
If you resolve conflicts and push a change, it will run. |
excitement-engineer
added some commits
Dec 28, 2017
excitement-engineer commentedDec 23, 2017
This PR removes the only react-native test in the repo. I don’t really see the value of including this test in the repo, in addition it adds complexity with the jest configurations and adds some other devDependencies which can now be removed.