New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated lint rule to make prettier responsible for formatting. #1452

Merged
merged 2 commits into from Dec 23, 2017

Conversation

Projects
None yet
3 participants
@excitement-engineer
Copy link
Collaborator

excitement-engineer commented Dec 23, 2017

Following #1449, attempt 2 at making prettier responsible for formatting.

I used a tool to remove all the lint rules that conflicted with prettier in the tslint.json. I also tested it on the file Query.tsx that is causing issues in #1448.

This allowed me to remove tslint-config-prettier as a dependency.

Finally, I also updated the pretty script and the lint-staged script in the package.json.

@excitement-engineer

This comment has been minimized.

Copy link
Collaborator Author

excitement-engineer commented Dec 23, 2017

@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Dec 23, 2017

Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

@rosskevin rosskevin merged commit 5a56897 into apollographql:master Dec 23, 2017

3 checks passed

CLA Author has signed the Meteor CLA.
Details
bundlesize ./dist/index.min.js: 6.95KB (9B larger than master, careful!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment