Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove copied shallowEqual code - use fbjs #1465
Conversation
rosskevin
added some commits
Dec 26, 2017
rosskevin
assigned
excitement-engineer
Dec 26, 2017
This comment has been minimized.
This comment has been minimized.
meteor-bot
commented
Dec 26, 2017
•
Generated by |
excitement-engineer
approved these changes
Dec 26, 2017
rosskevin
merged commit de1edc8
into
apollographql:master
Dec 26, 2017
rosskevin
deleted the
rosskevin:remove-copied-shallowequal
branch
Dec 26, 2017
This comment has been minimized.
This comment has been minimized.
evocateur
commented
Nov 7, 2018
|
Adding a dependency on fbjs for one function seems a rather Pyrrhic victory. Now anyone bundling this library gets a giant blob of unused, non-tree-shakeable code. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rosskevin commentedDec 26, 2017
shallowEqualand delegate tofbjsimport = requireof commonjs modules