New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copied shallowEqual code - use fbjs #1465

Merged
merged 3 commits into from Dec 26, 2017

Conversation

Projects
None yet
4 participants
@rosskevin
Copy link
Collaborator

rosskevin commented Dec 26, 2017

  • Remove copied code shallowEqual and delegate to fbjs
  • change tsconfig.json to allow for direct import = require of commonjs modules

rosskevin added some commits Dec 26, 2017

@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Dec 26, 2017

Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

@rosskevin rosskevin merged commit de1edc8 into apollographql:master Dec 26, 2017

3 checks passed

CLA Author has signed the Meteor CLA.
Details
bundlesize ./lib/react-apollo.browser.umd.js: 370B (6.02KB smaller than master, good job!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rosskevin rosskevin deleted the rosskevin:remove-copied-shallowequal branch Dec 26, 2017

@evocateur

This comment has been minimized.

Copy link

evocateur commented Nov 7, 2018

Adding a dependency on fbjs for one function seems a rather Pyrrhic victory. Now anyone bundling this library gets a giant blob of unused, non-tree-shakeable code. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment