New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import/export/package cleanup #1467

merged 7 commits into from Dec 26, 2017


None yet
1 participant
Copy link

rosskevin commented Dec 26, 2017

Goal: Address inconsistencies with import/exports, some type naming, and package creation

Summary: Ultimately, we were building and maintaining a browser.ts and server.ts and the payoff was negligible. Simplify indexes/builds/imports/exports and related names for consistency.

  • use index.ts as primary accumulation of exports
  • update exported types to be more unique to avoid collisions (pattern is set by Query.tsx more work needed here as we refactor graphql.tsx into Query/Mutate/Subscribe)
  • update deprecated rollup configs
  • measure only react-apollo.umd.js bundle (so small this is not worth maintaining/compiling two packages)
  • reduce bundlesize limit to help show errors
  • adjust to point to correct files
  • revert tsconfig (mine) change to unsure es2015 is produced for optional package.module use
  • move umd output in package to umd dir

@rosskevin rosskevin merged commit 5696fb8 into apollographql:master Dec 26, 2017

3 checks passed

CLA Author has signed the Meteor CLA.
bundlesize ./lib/umd/react-apollo.umd.js: 6.31KB
continuous-integration/travis-ci/pr The Travis CI build passed

@rosskevin rosskevin deleted the rosskevin:import-export-cleanup branch Dec 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment